Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix debug-port-cluster flakiness #4258

Closed

Conversation

santigimeno
Copy link
Member

The test was assuming that the all workers are running text was received
by the parent process in a separate chunk from the other texts. This might
not always be the case, causing the test never reaches the exit condition.
Fix it by checking every line received.

This test was timing out from time to time in OS X. To check what the problem was, I added the index
of the lines array into the log and could verify what I described before:

/usr/bin/python tools/test.py --mode=release message parallel sequential -J
=== release test-debug-port-cluster ===                                        
Path: parallel/test-debug-port-cluster
0> Debugger listening on port 13783
0> Debugger listening on port 13784
1> Debugger listening on port 13785
2> all workers are running
Command: out/Release/node /Users/sgimeno/node/node/test/parallel/test-debug-port-cluster.js
--- TIMEOUT ---

The test was assuming that the 'all workers are running' text was received
by the parent process in a separate chunk from the other texts. This might
not always be the case, causing the test never reaches the exit condition.
Fix it by checking every line received.
@jasnell jasnell added lts-watch-v4.x test Issues and PRs related to the tests. labels Dec 12, 2015
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. debugger labels Dec 12, 2015
@bnoordhuis
Copy link
Member

Great minds... I filed #4310 just now for the same issue.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 16, 2015

@santigimeno thank you for contributing this. For now, I'm going to close this in favor of #4310, which greatly simplifies the test IMO.

@santigimeno
Copy link
Member Author

It makes sense. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants