src: fix syntax error not showing in stderr with node --inspect-brk

[cola119]

Fixed #41792

When an uncaught exception occurs with inspector enabled, node::errors::TriggerUncaughtException will let an inspector agent send the error report.

node/src/node_errors.cc

Line 336 in 6e54851

report_to_inspector();

After reporting errors, the inspector agent waits for the client to disconnect. But this means the agent stops the following process and shows nothing in stderr.

Ideally, AtExit hook should be responsible for disconnection of inspector and the error reporters should send error information only. An inspector agent has no reason to wait for disconnection since the disconnection process is already registered to AtExit hook.

node/src/inspector_agent.cc

Lines 711 to 716 in 6e54851

	AtExit(parent_env_, [](void* env) {
	Agent* agent = static_cast<Environment*>(env)->inspector_agent();
	if (agent->IsActive()) {
	agent->WaitForDisconnect();
	}
	}, parent_env_);

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43198/

[jkrems]

I'm not sure if I fully understand the implications of removing WaitForDisconnect here. It seems okay but maybe somebody from @nodejs/v8 or @nodejs/v8-inspector has the full picture?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/44082/