Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: bind keystroke ctrl+6 to redo #41662

Merged
merged 3 commits into from
Feb 7, 2022
Merged

readline: bind keystroke ctrl+6 to redo #41662

merged 3 commits into from
Feb 7, 2022

Conversation

rayw000
Copy link
Contributor

@rayw000 rayw000 commented Jan 23, 2022

  1. Any keystroke emits 0x1E will do redo action.
  2. Fix bug of undo/redo.
  3. More detailed document.
  4. Unit tests.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Jan 23, 2022
Trott
Trott reviewed Jan 23, 2022
View reviewed changes
doc/api/readline.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 23, 2022
View reviewed changes
doc/api/readline.md Outdated Show resolved Hide resolved
@rayw000
readline: bind keystroke ctrl+6 to redo
87649ad 
1. Any keystroke emits `0x1E` will do redo action.
2. Fix bug of undo/redo.
3. More detailed document.
4. Unit tests.
@rayw000
grammatical fixing
39c1a7e
@rayw000
use primordials instead
a6bf5b8
aduh95
aduh95 approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this be labeled semver-minor?

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42108/

This was referenced Jan 24, 2022
Open
Open
Open
Open
Open
@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42204/

This was referenced Jan 29, 2022
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42361/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42382/

@github-actions github-actions bot mentioned this pull request Feb 6, 2022
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42399/

@github-actions github-actions bot mentioned this pull request Feb 7, 2022
Open
29 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42412/

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2022
@Mesteery Mesteery added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit a066857 into nodejs:master Feb 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a066857

This was referenced Feb 8, 2022
Open
Open
Open
Open
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@rayw000 @bengl
readline: bind keystroke ctrl+6 to redo
3243701 
1. Any keystroke emits `0x1E` will do redo action.
2. Fix bug of undo/redo.
3. More detailed document.
4. Unit tests.

PR-URL: nodejs#41662
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bengl bengl mentioned this pull request Feb 21, 2022
Merged
bengl added a commit that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
283a61f 
* 326f545 - doc: deprecate notice for process methods (Yash Ladha) #41587
* abd6967 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
* b968d89 - build: remove broken x32 arch support (Ben Noordhuis) [#41905](#41905)
* 88cbceb - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](#41938)
* ba639d0 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) [#36328](#36328)
* 1e862b3 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](#41819)
* 4fbe064 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) [#41956](#41956)
* 3243701 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) [#41662](#41662)
* 5796c3a - process: deprecate multipleResolves (Benjamin Gruenbaum) [#41872](#41872)
  * Documentation-only.

* \[[`811f04bd34`](811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](#42039)
* \[[`605271ba8c`](605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](#41955)
* \[[`0a6f0b416f`](0a6f0b416f)] - **deps**: upgrade npm to 8.5.0 (npm-robot) [#41925](#41925)

* \[[`7c19c7496e`](7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](#41991)
* \[[`0de611f53a`](0de611f53a)] - **doc**: add joesepi to collaborators (Joe Sepi) [#41914](#41914)

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
3461360 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) #41938
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
@rayw000 rayw000 deleted the feature-bind-redo branch February 22, 2022 06:43
@rayw000 rayw000 restored the feature-bind-redo branch February 22, 2022 06:44
@rayw000 rayw000 deleted the feature-bind-redo branch February 22, 2022 06:50
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
caadf9d 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
39ae944 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
6c7f304 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
972dd0a 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
BethGriggs pushed a commit that referenced this pull request Feb 22, 2022
@bengl @BethGriggs
2022-02-22, Version 17.6.0 (Current)
a987f7f 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
Trott pushed a commit that referenced this pull request Feb 23, 2022
@bengl @Trott
2022-02-22, Version 17.6.0 (Current)
175638b 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
@danielleadams
Copy link
Member

@rayw000 this doesn't land cleanly in 16.x - do you mind making a backport PR?

@rayw000
Copy link
Contributor Author

rayw000 commented Apr 11, 2022 •
edited
Loading

@rayw000 this doesn't land cleanly in 16.x - do you mind making a backport PR?

This PR relies on #37947, which is similar to #41392. It may not be appropriate to backport #37947 since it is a semver major change. @danielleadam

@rayw000 rayw000 mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rayw000 @nodejs-github-bot @danielleadams @jasnell @Trott @aduh95 @Mesteery