tools: remove conditional assignment in custom ESLint rule #41325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is a bit cosmetic, so I should explain my eventual goal: I'd like to be able to enable ESLint's recommended rule set (disabling a few rules as necessary) and this file is flagged for the conditional assignment. I don't feel strongly that this version is a big improvement so if others don't see it that way, oh well, we can close it. But I don't think it makes the code worse either. |
|
@nodejs/linting |
Trott
force-pushed
the
no-cond-assign
branch
from
555b6f5 to
596c45b
Compare
Trott
changed the title
|
I think it's possible to silence the eslint error by wrapping the assignment in parentheses |
Yes, that is correct. I considered that, but |
@targos Do you have opinions as to which options are preferable and which should be avoided?
|
targos
approved these changes
Jan 3, 2022
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
25 tasks
26 tasks
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/41325 ✔ Done loading data for nodejs/node/pull/41325 ----------------------------------- PR info ------------------------------------ Title tools: remove conditional assignment in custom ESLint rule (#41325) Author Rich Trott (@Trott) Branch Trott:no-cond-assign -> nodejs:master Labels tools, author ready Commits 1 - tools: remove conditional assignment in custom ESLint rule Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41325 Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41325 Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 26 Dec 2021 03:55:17 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41325#pullrequestreview-842514715 ✖ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1657795258 |
aduh95
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/41325 ✔ Done loading data for nodejs/node/pull/41325 ----------------------------------- PR info ------------------------------------ Title tools: remove conditional assignment in custom ESLint rule (#41325) Author Rich Trott (@Trott) Branch Trott:no-cond-assign -> nodejs:master Labels tools, author ready Commits 1 - tools: remove conditional assignment in custom ESLint rule Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41325 Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41325 Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 26 Dec 2021 03:55:17 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41325#pullrequestreview-842514715 ✖ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1658007831 |
These changes no-duplicate-require.js so that it doesn't use an assignment in a conditional, which can be easy to misread as a comparison rather than an assignment. It also means we change a do/while (which we don't use much in our code) to the much more common while construct. PR-URL: nodejs#41325 Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in e7d4e6b |
This was referenced Jan 6, 2022
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
These changes no-duplicate-require.js so that it doesn't use an assignment in a conditional, which can be easy to misread as a comparison rather than an assignment. It also means we change a do/while (which we don't use much in our code) to the much more common while construct. PR-URL: #41325 Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
These changes no-duplicate-require.js so that it doesn't use an assignment in a conditional, which can be easy to misread as a comparison rather than an assignment. It also means we change a do/while (which we don't use much in our code) to the much more common while construct. PR-URL: #41325 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
These changes no-duplicate-require.js so that it doesn't use an assignment in a conditional, which can be easy to misread as a comparison rather than an assignment. It also means we change a do/while (which we don't use much in our code) to the much more common while construct. PR-URL: nodejs#41325 Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
These changes no-duplicate-require.js so that it doesn't use an assignment in a conditional, which can be easy to misread as a comparison rather than an assignment. It also means we change a do/while (which we don't use much in our code) to the much more common while construct. PR-URL: #41325 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes no-duplicate-require.js so that it doesn't use an
assignment in a conditional, which can be easy to misread as a
comparison rather than an assignment. It also means we change a do/while
(which we don't use much in our code) to the much more common while
construct.