Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify entry point behavior when using loader hooks #41304

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 23, 2021

Fixes: #41275

//cc @nodejs/loaders

@aduh95 aduh95 added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 25, 2021
doc/api/esm.md Outdated Show resolved Hide resolved
Co-authored-by: Geoffrey Booth <456802+GeoffreyBooth@users.noreply.github.com>
@aduh95 aduh95 merged commit b490805 into nodejs:master Jan 5, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 5, 2022

Landed in b490805

@aduh95 aduh95 deleted the hooks-entry-point branch January 5, 2022 09:54
targos pushed a commit that referenced this pull request Jan 14, 2022
Fixes: #41275

PR-URL: #41304
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Fixes: #41275

PR-URL: #41304
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Fixes: nodejs#41275

PR-URL: nodejs#41304
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Fixes: #41275

PR-URL: #41304
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM hooks used for entry module
6 participants