Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: add missing initialization of last error #41290

Closed
wants to merge 1 commit into from
Closed

node-api: add missing initialization of last error #41290

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

  • Add missing initiatlization of last error which
    was reported by coverity.

Signed-off-by: Michael Dawson mdawson@devrus.com

@mhdawson
node-api: add missing initialization of last error
02453b0 
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2021 •
edited by mhdawson
Loading

Review requested:

  • @nodejs/n-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 22, 2021
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41635/

@github-actions github-actions bot mentioned this pull request Dec 24, 2021
Open
18 tasks
This was referenced Dec 25, 2021
Open
Open
Open
Open
Open
Open
This was referenced Dec 31, 2021
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41739/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41747/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41748/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41749/

@mhdawson
Copy link
Member Author

mhdawson commented Jan 4, 2022

Looks like CI is complete even though UI still shows one check as pending, going to land.

mhdawson added a commit that referenced this pull request Jan 4, 2022
@mhdawson
node-api: add missing initialization of last error
3f403e5 
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Jan 4, 2022

Landed in 3f403e5

@mhdawson mhdawson closed this Jan 4, 2022
This was referenced Jan 5, 2022
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 13, 2022
Open
18 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson @targos
node-api: add missing initialization of last error
5fe011a 
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@mhdawson @danielleadams
node-api: add missing initialization of last error
32282f5 
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@mhdawson @Linkgoron
node-api: add missing initialization of last error
285339e 
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson @danielleadams
node-api: add missing initialization of last error
03490cb 
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @nodejs-github-bot @jasnell @lpinca @tniessen @JungMinu