Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use '<(python)' instead of 'python' #41146

Merged
merged 1 commit into from
Dec 16, 2021
Merged

build: use '<(python)' instead of 'python' #41146

merged 1 commit into from
Dec 16, 2021

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 12, 2021

Should use <(python) instead of python for scripts in gyp files, otherwise the scripts might be run with python2 on some environments.

Close #40996.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 12, 2021
@Trott Trott added python PRs and issues that require attention from people who are familiar with Python. gyp Issues and PRs related to the GYP tool and .gyp build files labels Dec 12, 2021
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41468/

This was referenced Dec 13, 2021
Open
Open
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41485/

@gengjiawen gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 14, 2021
@github-actions github-actions bot mentioned this pull request Dec 15, 2021
Open
24 tasks
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41495/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41496/

@github-actions github-actions bot mentioned this pull request Dec 16, 2021
Open
20 tasks
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2021
@nodejs-github-bot nodejs-github-bot merged commit e56bf50 into nodejs:master Dec 16, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in e56bf50

danielleadams pushed a commit that referenced this pull request Dec 16, 2021
@zcbenz @danielleadams
build: use '<(python)' instead of 'python'
c658881 
PR-URL: #41146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 16, 2021
Merged
This was referenced Dec 16, 2021
Closed
Closed
@github-actions github-actions bot mentioned this pull request Dec 17, 2021
Open
22 tasks
danielleadams pushed a commit that referenced this pull request Dec 17, 2021
@zcbenz @danielleadams
build: use '<(python)' instead of 'python'
3a9ffa8 
PR-URL: #41146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This was referenced Dec 18, 2021
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@zcbenz @danielleadams
build: use '<(python)' instead of 'python'
26f8791 
PR-URL: #41146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@zcbenz @danielleadams
build: use '<(python)' instead of 'python'
f472dcb 
PR-URL: #41146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@zcbenz @Linkgoron
build: use '<(python)' instead of 'python'
5f3abbb 
PR-URL: nodejs#41146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@zcbenz @danielleadams
build: use '<(python)' instead of 'python'
93450e5 
PR-URL: #41146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build failed on macOS
5 participants
@zcbenz @nodejs-github-bot @lpinca @gengjiawen @Trott