Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,crypto: remove uses of AllocatedBuffer from crypto_sig #40895

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 20, 2021
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 21, 2021
@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2021
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/40895
✔  Done loading data for nodejs/node/pull/40895
----------------------------------- PR info ------------------------------------
Title      src,crypto: remove uses of `AllocatedBuffer` from `crypto_sig` (#40895)
Author     Darshan Sen  (@RaisinTen)
Branch     RaisinTen:src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_sig -> nodejs:master
Labels     crypto, c++, author ready
Commits    1
 - src,crypto: remove uses of `AllocatedBuffer` from `crypto_sig`
Committers 1
 - Darshan Sen 
PR-URL: https://github.com/nodejs/node/pull/40895
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40895
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 20 Nov 2021 14:52:50 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40895#pullrequestreview-811856756
   ✖  This PR needs to wait 5 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-11-21T05:00:27Z: https://ci.nodejs.org/job/node-test-pull-request/41019/
- Querying data for job/node-test-pull-request/41019/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1510147352

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 27, 2021
@RaisinTen RaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 27, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2021
@nodejs-github-bot nodejs-github-bot merged commit 90faf55 into nodejs:master Nov 27, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 90faf55

@RaisinTen RaisinTen deleted the src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_sig branch November 27, 2021 16:00
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40895
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40895
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40895
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40895
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants