Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: explain backport labels #40520

Merged
merged 1 commit into from
Oct 22, 2021
Merged

doc: explain backport labels #40520

merged 1 commit into from
Oct 22, 2021

Conversation

Qard
Copy link
Member

@Qard Qard commented Oct 19, 2021

Just adding a list of relevant labels to the backport guide to make it easier to understand how to label backport/lts issues and PRs.

@Qard Qard added the doc Issues and PRs related to the documentations. label Oct 19, 2021
@tniessen
Copy link
Member

Could you format this to match #40358?

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qard
Copy link
Member Author

Qard commented Oct 19, 2021

@tniessen Done. Didn't know that existed. 😅

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Qard
Copy link
Member Author

Qard commented Oct 19, 2021

Just one more tiny fix to arrange it alphabetically. :)

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 19, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95
Copy link
Contributor

aduh95 commented Oct 20, 2021

There could be a comment regarding dont-land-… labels also.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qard Qard added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 20, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40520
✔  Done loading data for nodejs/node/pull/40520
----------------------------------- PR info ------------------------------------
Title      doc: explain backport labels (#40520)
Author     Stephen Belanger  (@Qard)
Branch     Qard:document-backport-labels -> nodejs:master
Labels     doc, fast-track
Commits    1
 - doc: explain backport labels
Committers 1
 - Stephen Belanger 
PR-URL: https://github.com/nodejs/node/pull/40520
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40520
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 19 Oct 2021 15:40:34 GMT
   ✔  Approvals: 7
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-783489714
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-783532267
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-783510129
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40520#pullrequestreview-783639459
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-784251470
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-784562298
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-784776392
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1364900936

@Qard Qard added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 20, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2021
@nodejs-github-bot
Copy link
Collaborator

@Qard Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2021
@nodejs-github-bot
Copy link
Collaborator

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021
@Qard Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2021
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 22, 2021
PR-URL: #40520
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Oct 22, 2021

Landed in f743054

@aduh95 aduh95 merged commit f743054 into master Oct 22, 2021
@aduh95 aduh95 deleted the document-backport-labels branch October 22, 2021 22:09
targos pushed a commit that referenced this pull request Oct 23, 2021
PR-URL: #40520
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
PR-URL: #40520
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants