Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include new public V8 headers in distribution #40423

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 12, 2021

v8.h was split into a multitude of smaller headers.

Refs: #39876

v8.h was split into a multitude of smaller headers.

Refs: nodejs#39876
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Oct 12, 2021
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2021
@nodejs-github-bot
Copy link
Collaborator

@Mesteery Mesteery removed the needs-ci PRs that need a full CI run. label Oct 12, 2021
@nodejs-github-bot
Copy link
Collaborator

@BethGriggs BethGriggs added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 13, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @BethGriggs. Please 👍 to approve.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

Landed in f9996d5

@mhdawson mhdawson closed this Oct 13, 2021
mhdawson pushed a commit that referenced this pull request Oct 13, 2021
v8.h was split into a multitude of smaller headers.

Refs: #39876

PR-URL: #40423
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos deleted the fix-install-py branch October 14, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants