Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor internal debug variable #40364

Closed

Conversation

gdccwxx
Copy link
Contributor

@gdccwxx gdccwxx commented Oct 7, 2021

  • refractor internal/debugger/inspect_client.js to use let.
  • move variable into each for loop

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Oct 7, 2021
@Lxxyx
Copy link
Member

Lxxyx commented Oct 7, 2021

nit: The pull request title should start with lib:

@Lxxyx Lxxyx added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 7, 2021
@gdccwxx gdccwxx changed the title Lib/refactor internal debug variable lib/refactor internal debug variable Oct 7, 2021
@gdccwxx gdccwxx changed the title lib/refactor internal debug variable lib: refactor internal debug variable Oct 7, 2021
move variable into each for loop
@gdccwxx gdccwxx force-pushed the lib/refactor-internal-debug-variable branch from 2f6e1e1 to 604d0d4 Compare October 7, 2021 14:53
@Lxxyx Lxxyx added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2021
@nodejs-github-bot
Copy link
Collaborator

@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2021
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Landed in eafdeab...ac4f5e2

@github-actions github-actions bot closed this Oct 9, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 9, 2021
move variable into each for loop

PR-URL: #40364
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
move variable into each for loop

PR-URL: #40364
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlau richardlau mentioned this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants