Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: support array of streams in promises pipeline #40193

Closed
wants to merge 4 commits into from

Conversation

Mesteery
Copy link
Contributor

Fixes: #40191

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 23, 2021
@lpinca
Copy link
Member

lpinca commented Sep 23, 2021

It should be already supported

if (ArrayIsArray(streams[0]) && streams.length === 1) {
streams = streams[0];
}
no?

@Mesteery Mesteery added the stream Issues and PRs related to the stream subsystem. label Sep 23, 2021
@Mesteery
Copy link
Contributor Author

Mesteery commented Sep 23, 2021

Since c04d621, promises.pipeline calls directly pipelineImpl:

const { pipelineImpl: pl } = require('internal/streams/pipeline');

@lpinca
Copy link
Member

lpinca commented Sep 23, 2021

Ah ok. Can you please add a test?

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Ayase-252
Copy link
Member

Landed in b920a10

@Ayase-252 Ayase-252 closed this Oct 20, 2021
Ayase-252 pushed a commit that referenced this pull request Oct 20, 2021
Fixes: #40191

PR-URL: #40193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Mesteery Mesteery deleted the patch-2 branch October 20, 2021 11:56
targos pushed a commit that referenced this pull request Oct 20, 2021
Fixes: #40191

PR-URL: #40193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Oct 20, 2021
Notable changes:

Fixed distribution for native addon builds

This release fixes an issue introduced in Node.js v17.0.0, where some V8
headers were missing from the distributed tarball, making it impossible
to build native addons. These headers are now included.
#40526

Fixed stream issues
* Fixed a regression in `stream.promises.pipeline`, which was introduced
  in version 16.10.0, is fixed. It is now possible again to pass an
  array of streams to the function.
  #40193
* Fixed a bug in `stream.Duplex.from`, which didn't work properly when
  an async generator function was passed to it.
  #40499

PR-URL: #40535
targos added a commit that referenced this pull request Oct 20, 2021
Notable changes:

Fixed distribution for native addon builds

This release fixes an issue introduced in Node.js v17.0.0, where some V8
headers were missing from the distributed tarball, making it impossible
to build native addons. These headers are now included.
#40526

Fixed stream issues
* Fixed a regression in `stream.promises.pipeline`, which was introduced
  in version 16.10.0, is fixed. It is now possible again to pass an
  array of streams to the function.
  #40193
* Fixed a bug in `stream.Duplex.from`, which didn't work properly when
  an async generator function was passed to it.
  #40499

PR-URL: #40535
targos pushed a commit that referenced this pull request Nov 4, 2021
Fixes: #40191

PR-URL: #40193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream.promises.pipeline doesn't support arrays of streams since node 16.10
7 participants