Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: refactor and use validators #40022

Closed
wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

The logical NOT operator and validators should be used where appropriate.

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Sep 6, 2021
@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 15, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 15, 2021
The logical NOT operator and validators should be used where
appropriate.
@VoltrexKeyva
Copy link
Member Author

Merge conflict resolved.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 17, 2021
targos pushed a commit that referenced this pull request Sep 18, 2021
The logical NOT operator and validators should be used where
appropriate.

PR-URL: #40022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@targos
Copy link
Member

targos commented Sep 18, 2021

Landed in 7c77db0

@targos
Copy link
Member

targos commented Oct 4, 2021

Needs a backport PR to land on v16.x.

targos pushed a commit that referenced this pull request Oct 9, 2021
The logical NOT operator and validators should be used where
appropriate.

PR-URL: #40022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@targos
Copy link
Member

targos commented Oct 9, 2021

Actually landed in 03c2432. The conflict was easy.

danielleadams pushed a commit that referenced this pull request Oct 12, 2021
The logical NOT operator and validators should be used where
appropriate.

PR-URL: #40022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@richardlau richardlau mentioned this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dns Issues and PRs related to the dns subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants