Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,meta: update email addresses for misterdjules #39433

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 19, 2021

Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
update-authors.js so they only have one entry in AUTHORS.

@Trott Trott requested a review from misterdjules July 19, 2021 04:46
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Jul 19, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: nodejs#39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 21, 2021

Landed in 5100c3c

@Trott Trott merged commit 5100c3c into nodejs:master Jul 21, 2021
@Trott Trott deleted the mdj branch July 21, 2021 05:02
targos pushed a commit that referenced this pull request Jul 21, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: #39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
@misterdjules
Copy link

Thank you @Trott, and sorry I didn't notice this PR until now.

richardlau pushed a commit that referenced this pull request Jul 29, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: #39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: #39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: #39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants