Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: align module resolve algorithm with implementation #38837

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

Ayase-252
Copy link
Member

In docs, it reads like GLOBAL_FOLDERS takes precedence over node_module, but in implementation, GLOBAL_FOLDERS is appended to the last of paths to resolve. It should take lowest priority.

paths = ArrayPrototypeConcat(parent.paths, paths);

Fixes: #38128

@github-actions github-actions bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels May 29, 2021
doc/api/modules.md Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented May 29, 2021

@nodejs/modules

doc/api/modules.md Outdated Show resolved Hide resolved
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Christopher Beeson <christopher@bl-ue.com>
doc/api/modules.md Outdated Show resolved Hide resolved
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@Ayase-252
Copy link
Member Author

It seems that GH action build-windows is quite unstable?

@kongmoumou
Copy link

When will this PR be merged 😂

@aduh95 aduh95 merged commit ea977fc into nodejs:master Dec 14, 2021
@aduh95
Copy link
Contributor

aduh95 commented Dec 14, 2021

Landed in ea977fc

danielleadams pushed a commit that referenced this pull request Dec 16, 2021
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 17, 2021
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Fixes: nodejs#38128

PR-URL: nodejs#38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NODE_PATH documentation appears to be incorrect
6 participants