Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: use Object.create(null) for dictionary object #3831

Closed
wants to merge 1 commit into from
Closed

util: use Object.create(null) for dictionary object #3831

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

Fixes #3788
arrayToHash() needs to use Object.create(null) for its dictionary object.

@JungMinu
util: use Object.create(null) for dictionary object
91952b6 
Fixes #3788
`arrayToHash()` needs to use `Object.create(null)` for its dictionary object.
@JungMinu JungMinu mentioned this pull request Nov 15, 2015
Closed
@thefourtheye thefourtheye added the util Issues and PRs related to the built-in util module. label Nov 15, 2015
@jasnell
Copy link
Member

jasnell commented Nov 16, 2015

Given the LGTM's in the prior PR, will get this landed.

jasnell pushed a commit that referenced this pull request Nov 16, 2015
@JungMinu @jasnell
util: use Object.create(null) for dictionary object
9d0396c 
Fixes #3788
`arrayToHash()` needs to use `Object.create(null)` for its dictionary object.

Refs: #3791
PR-URL: #3831
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 16, 2015

Landed in 9d0396c

@jasnell jasnell closed this Nov 16, 2015
@evanlucas
Copy link
Contributor

This should probably be semver-major?

@jasnell
Copy link
Member

jasnell commented Nov 16, 2015

@nodejs/ctc ... any thoughts on the semver-iness of this change?

@cjihrig
Copy link
Contributor

cjihrig commented Nov 16, 2015

This is a grey area. I would consider it a bug fix, but technically someone could be depending on the brackets described in #3788.

@trevnorris
Copy link
Contributor

I'd say bug fix as well.

Fishrock123 pushed a commit that referenced this pull request Nov 17, 2015
@JungMinu @Fishrock123
util: use Object.create(null) for dictionary object
d61cb90 
Fixes #3788
`arrayToHash()` needs to use `Object.create(null)` for its dictionary object.

Refs: #3791
PR-URL: #3831
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
@jasnell
Copy link
Member

jasnell commented Dec 17, 2015

Given the nature of the change and the possibility that this could break someone, I'm not going to pull this into v4 at all.

@MylesBorins MylesBorins mentioned this pull request Jan 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JungMinu @jasnell @evanlucas @cjihrig @trevnorris @rvagg @thefourtheye