Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] deps: V8 parent ordering fix backport #37973

Closed

Conversation

guybedford
Copy link
Contributor

This is a backport of #37864 for 14.x. Getting this v8 patch to land cleanly required also porting v8/v8@5f90cfd which I've included as a separate commit in this PR.

This would be a very useful backport to ensure that between Node.js 14 and up, top-level await execution ordering semantics will always be well-defined and to specification.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v14.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 29, 2021
@guybedford guybedford requested a review from targos March 29, 2021 23:46
@nodejs-github-bot

This comment has been minimized.

@guybedford guybedford force-pushed the v8-cycle-fix-backport-14 branch 2 times, most recently from b74b214 to 3537fff Compare March 30, 2021 11:52
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2021

common.gypi Outdated
@@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.20',
'v8_embedder_string': '-node.21',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above says this should be incremented for each non-official patch, so probably each commit in this PR should bump the version up by one.

@guybedford guybedford changed the title [v14.x] deps: V8 cycle fix backport [v14.x] deps: V8 parent ordering fix backport Apr 1, 2021
[torque] Move SourceTextModule flags definitions to Torque

Refs: v8/v8@5f90cfd
PR-URL: nodejs#37973
Reviewed-By: Richard Lau <rlau@redhat.com>
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

@guybedford guybedford changed the base branch from v14.x-staging to v14.x April 8, 2021 22:48
@guybedford guybedford changed the base branch from v14.x to v14.x-staging April 8, 2021 22:53
guybedford added a commit that referenced this pull request Apr 14, 2021
[torque] Move SourceTextModule flags definitions to Torque

Refs: v8/v8@5f90cfd
PR-URL: #37973
Reviewed-By: Richard Lau <rlau@redhat.com>
guybedford added a commit that referenced this pull request Apr 14, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Backport-PR-URL: #37973
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@guybedford
Copy link
Contributor Author

Landed in dd5da30 and 0c1e878.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants