Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in lib/internal/modules/esm/module_job.js #37773

Merged
merged 1 commit into from
Mar 19, 2021
Merged

doc: fix typo in lib/internal/modules/esm/module_job.js #37773

merged 1 commit into from
Mar 19, 2021

Conversation

marsonya
Copy link
Member

'destructuring' spelled as 'descructuring'

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 16, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels Mar 16, 2021
@aduh95
Copy link
Contributor

aduh95 commented Mar 16, 2021

fast-track?

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Mar 19, 2021
@marsonya @aduh95
lib: fix typo in internal/modules/esm/module_job.js
b079960 
PR-URL: #37773
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Mar 19, 2021

Landed in b079960

@aduh95 aduh95 closed this Mar 19, 2021
@aduh95 aduh95 merged commit b079960 into nodejs:master Mar 19, 2021
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@marsonya @ruyadorno
lib: fix typo in internal/modules/esm/module_job.js
6e2b609 
PR-URL: #37773
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
lib: fix typo in internal/modules/esm/module_job.js
13ac680 
PR-URL: #37773
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@antsmartian antsmartian antsmartian approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marsonya @aduh95 @antsmartian @cjihrig @richardlau @Lxxyx @PoojaDurgad @nodejs-github-bot