Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add gyp maintain info #37765

Closed
wants to merge 1 commit into from
Closed

doc: add gyp maintain info #37765

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

cc @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 16, 2021
richardlau
richardlau reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for mentioning the team (that if you are not in the nodejs org in GitHub you won't be able to see) in the API docs?

If the intention is to call out that upstream for GYP is now gyp-next, perhaps instead of a tacked on sentence the original paragraph could be reworded to something like:

node-gyp is a build system based on the gyp-next fork of Google's GYP tool...

doc/api/n-api.md Outdated Show resolved Hide resolved
@gengjiawen
Copy link
Member Author

@richardlau PTAL

richardlau
richardlau approved these changes Mar 16, 2021
View reviewed changes
doc/api/n-api.md Outdated Show resolved Hide resolved
@gengjiawen
Copy link
Member Author

Landed in a2fdef0

@gengjiawen gengjiawen closed this Mar 18, 2021
gengjiawen added a commit that referenced this pull request Mar 18, 2021
@gengjiawen
doc: add gyp maintain info
a2fdef0 
PR-URL: #37765
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gengjiawen gengjiawen deleted the doc/gyp branch March 18, 2021 07:42
ruyadorno pushed a commit that referenced this pull request Mar 20, 2021
@gengjiawen @ruyadorno
doc: add gyp maintain info
2e82a97 
PR-URL: #37765
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@gengjiawen @targos
doc: add gyp maintain info
fe0f6a5 
PR-URL: #37765
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@richardlau richardlau richardlau approved these changes

@mmarchini mmarchini mmarchini approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @Trott @cjihrig @mmarchini @richardlau @ryzokuken @marsonya @nodejs-github-bot