crypto: reconcile duplicated code #37704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
panva
approved these changes
Mar 11, 2021
panva
added
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Mar 13, 2021
|
Landed in e76d762 |
panva
pushed a commit
that referenced
this pull request
Mar 13, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37704 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37704 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37704 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @panva
Signed-off-by: James M Snell jasnell@gmail.com