Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: default to verbatim=true in dns.lookup() #37681

Closed
wants to merge 27 commits into from
Closed

dns: default to verbatim=true in dns.lookup() #37681

wants to merge 27 commits into from

Commits on Mar 13, 2021

  1. dns: default to verbatim=true in dns.lookup() 

    Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Reissue of nodejs#31567
    @bnoordhuis @treysis
    bnoordhuis authored and treysis committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    5bef0de View commit details
    Browse the repository at this point in the history

  2. Fixes for IPv6 compatibility; new const 'common.localhostIP'

    @treysis
    treysis committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    4be87a0 View commit details
    Browse the repository at this point in the history

  3. Update test-net-dns-lookup.js

    @treysis
    treysis committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    43d1492 View commit details
    Browse the repository at this point in the history

  4. Update test-net-dns-lookup.js

    @treysis
    treysis committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    beb6420 View commit details
    Browse the repository at this point in the history

  5. Fix test-net-dns-lookup.js

    @treysis
    treysis committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    604366c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @treysis @aduh95
    treysis and aduh95 committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    1bb0e55 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. IPv6 fixes

    @treysis
    treysis committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    16a1682 View commit details
    Browse the repository at this point in the history

  2. Update inspector-helper.js

    @treysis
    treysis committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    178683c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Revert "Fixes for IPv6 compatibility; new const 'common.localhostIP'" 

    This reverts commit 4be87a0.
    @treysis
    treysis committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    2b67c17 View commit details
    Browse the repository at this point in the history

  2. Update test-net-better-error-messages-port.js

    @treysis
    treysis committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    4b06383 View commit details
    Browse the repository at this point in the history

  3. Test suite fixes. Hardcode localhost IPv4.

    @treysis
    treysis committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6340f13 View commit details
    Browse the repository at this point in the history

  4. More localhost/127.0.0.1 fixes.

    @treysis
    treysis committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    2f7edf0 View commit details
    Browse the repository at this point in the history

  5. Update test-net-pingpong.js

    @treysis
    treysis committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    75bd959 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Update test/parallel/test-net-writable.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @treysis @aduh95
    treysis and aduh95 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    a19f8ec View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Update test-net-writable.js

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    0232a4a View commit details
    Browse the repository at this point in the history

  2. Update test-net-writable.js

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2ef88c7 View commit details
    Browse the repository at this point in the history

  3. Update test-net-writable.js

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    98b3ffb View commit details
    Browse the repository at this point in the history

  4. Update test-net-writable.js

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7a0e447 View commit details
    Browse the repository at this point in the history

  5. Update parallel.status

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    5037efc View commit details
    Browse the repository at this point in the history

  6. Update test-net-connect-options-port.js

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    787dc69 View commit details
    Browse the repository at this point in the history

  7. Update parallel.status

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    26f7f45 View commit details
    Browse the repository at this point in the history

  8. Update test-net-connect-options-port.js

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    269eda7 View commit details
    Browse the repository at this point in the history

  9. Update parallel.status

    @treysis
    treysis committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1928b44 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Updated from review

    @treysis
    treysis committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    5557b85 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Update test-net-remote-address-port.js

    @treysis
    treysis committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    bccf676 View commit details
    Browse the repository at this point in the history

  2. Update test/parallel/test-net-remote-address-port.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @treysis @aduh95
    treysis and aduh95 committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    0c8be88 View commit details
    Browse the repository at this point in the history

  3. Update test-net-better-error-messages-port.js

    @treysis
    treysis committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    7cae409 View commit details
    Browse the repository at this point in the history