Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline: replace _questionCancel with a symbol #37094

Closed
wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 27, 2021

This commit avoids exposing a new underscored property on
readline Interface instances.

This commit avoids exposing a new underscored property on
readline Interface instances.
@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Jan 27, 2021
@nodejs-github-bot
Copy link
Collaborator

@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2021
Lxxyx pushed a commit that referenced this pull request Jan 29, 2021
This commit avoids exposing a new underscored property on
readline Interface instances.

PR-URL: #37094
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Lxxyx
Copy link
Member

Lxxyx commented Jan 29, 2021

Landed in fec093b

@Lxxyx Lxxyx closed this Jan 29, 2021
@cjihrig cjihrig deleted the symbol branch January 29, 2021 14:45
targos pushed a commit that referenced this pull request Feb 2, 2021
This commit avoids exposing a new underscored property on
readline Interface instances.

PR-URL: #37094
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants