Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: use throwIfNoEntry option on statSync calls #36975

Merged
merged 0 commits into from
Jan 24, 2021
Merged

fs: use throwIfNoEntry option on statSync calls #36975

merged 0 commits into from
Jan 24, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 17, 2021

No description provided.

@aduh95 aduh95 added fs Issues and PRs related to the fs subsystem / file system. dont-land-on-v10.x labels Jan 17, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35588/

mscdex
mscdex reviewed Jan 17, 2021
View reviewed changes
lib/internal/fs/rimraf.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35592/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35593/

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35594/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@Trott
Copy link
Member

Trott commented Jan 24, 2021

Landed in a87190b

@Trott Trott closed this Jan 24, 2021
@Trott Trott merged commit a87190b into nodejs:master Jan 24, 2021
@aduh95 aduh95 deleted the fs-throwIfNoEntry branch January 24, 2021 18:10
targos pushed a commit that referenced this pull request Feb 2, 2021
@aduh95 @targos
fs: use throwIfNoEntry option on statSync calls
175f6f0 
PR-URL: #36975
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @nodejs-github-bot @Trott @mscdex @jasnell @Lxxyx @targos