Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix grammar and link to QUIC #36959

Closed
wants to merge 1 commit into from
Closed

[docs] Fix grammar and link to QUIC #36959

wants to merge 1 commit into from

Conversation

dandv
Copy link
Contributor

@dandv dandv commented Jan 16, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 16, 2021
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: QUICK -> QUIC

@dandv dandv changed the title [docs] Fix grammar and link to QUICK [docs] Fix grammar and link to QUIC Jan 16, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 16, 2021

Typo: QUICK -> QUIC

This can be fixed when landing, to avoid having to run another CI just to fix the commit message.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I wonder if the link should be https://developer.mozilla.org/en-US/docs/Glossary/QUIC rather than Wikipedia.

@aduh95
Copy link
Contributor

aduh95 commented Jan 18, 2021

@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection.

Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoever land this please fix commit message.

@gengjiawen gengjiawen self-requested a review January 18, 2021 11:38
@gengjiawen
Copy link
Member

@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection.

My objection is clear. But also this can be fixed by commiter, I have dismissed my objection with a comment.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@aduh95 aduh95 dismissed gengjiawen’s stale review January 18, 2021 14:04

They dismissed their objection in a comment above.

@aduh95
Copy link
Contributor

aduh95 commented Jan 18, 2021

Landed in 75a73c4

@aduh95 aduh95 closed this Jan 18, 2021
aduh95 pushed a commit that referenced this pull request Jan 18, 2021
PR-URL: #36959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@dandv dandv deleted the patch-2 branch January 19, 2021 03:02
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants