Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix module.isPreloading documentation #36944

Closed
wants to merge 1 commit into from
Closed

doc: fix module.isPreloading documentation #36944

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 15, 2021 •
edited
Loading

Refs: #36263
Fixes: #36775

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Jan 15, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2021
@jasnell
Copy link
Member

jasnell commented Jan 18, 2021

Landed in 9d7fb22

@jasnell jasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
@aduh95 @jasnell
doc: fix module.isPreloading documentation
9d7fb22 
Fixes: #36775

PR-URL: #36944
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 deleted the doc-module-isPreloading branch January 18, 2021 22:38
aduh95 added a commit to aduh95/node that referenced this pull request Jan 18, 2021
@aduh95
doc: fix module.isPreloading documentation
4569a65 
Fixes: nodejs#36775

PR-URL: nodejs#36944
Refs: nodejs#36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jan 18, 2021
Closed
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@aduh95 @ruyadorno
doc: fix module.isPreloading documentation
4980cf7 
Fixes: #36775

PR-URL: #36944
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@aduh95 @ruyadorno
doc: fix module.isPreloading documentation
d2d9ad7 
Fixes: #36775

PR-URL: #36944
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 25, 2021
@aduh95 @targos
doc: fix module.isPreloading documentation
7c9f3a9 
Fixes: #36775

PR-URL: #36944
Backport-PR-URL: #36988
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 25, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@ExE-Boss ExE-Boss ExE-Boss approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module.isPreloading doc doesn't match implementation
7 participants
@aduh95 @jasnell @lpinca @ExE-Boss @Flarna @targos @nodejs-github-bot