Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix variable name for non-RSA keys #36912

Closed
wants to merge 1 commit into from
Closed

test: fix variable name for non-RSA keys #36912

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

The point here is that the keys are not RSA keys, so the variable name rsaKeys is misleading/wrong. These ECDSA keys are used to test that the RSA algorithm rejects non-RSA keys.

@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. labels Jan 13, 2021
@tniessen tniessen requested a review from jasnell January 13, 2021 14:53
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2021
@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 13, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35549/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
tniessen added a commit that referenced this pull request Jan 15, 2021
@tniessen
test: fix variable name for non-RSA keys
ccc6776 
PR-URL: #36912
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen
Copy link
Member Author

Landed in ccc6776, thanks for reviewing.

@tniessen tniessen closed this Jan 15, 2021
@tniessen tniessen deleted the test-fix-rsa-key-var-name branch January 15, 2021 17:14
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@tniessen @ruyadorno
test: fix variable name for non-RSA keys
30b2aac 
PR-URL: #36912
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@panva panva panva approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @panva @lpinca @cjihrig @targos