Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify descriptions of _writev chunks argument #36822

Closed
wants to merge 1 commit into from
Closed

doc: clarify descriptions of _writev chunks argument #36822

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 6, 2021

Fixes: #36789
Signed-off-by: James M Snell jasnell@gmail.com

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jan 6, 2021
@jasnell jasnell requested a review from mcollina January 6, 2021 22:02
mcollina
mcollina approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2021
addaleax
addaleax reviewed Jan 8, 2021
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
doc/api/stream.md Outdated Show resolved Hide resolved
@jasnell
doc: clarify descriptions of _writev chunks argument
c62ae74 
Fixes: nodejs#36789
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the doc-clarify-writev branch from 5dc7a50 to c62ae74 Compare January 8, 2021 17:00
@jasnell
Copy link
Member Author

jasnell commented Jan 9, 2021

Landed in 96c3498

@jasnell jasnell closed this Jan 9, 2021
jasnell added a commit that referenced this pull request Jan 9, 2021
@jasnell
doc: clarify descriptions of _writev chunks argument
96c3498 
Fixes: #36789
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
doc: clarify descriptions of _writev chunks argument
1a4d34e 
Fixes: #36789
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: clarify descriptions of _writev chunks argument
f605bc0 
Fixes: #36789
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@watilde watilde watilde approved these changes

@antsmartian antsmartian antsmartian approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: description for chunks in _writev in stream_writable
6 participants
@jasnell @mcollina @addaleax @antsmartian @watilde @nodejs-github-bot