Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase buffer list coverage #36688

Closed
wants to merge 1 commit into from
Closed

test: increase buffer list coverage #36688

wants to merge 1 commit into from

Conversation

emilsivervik
Copy link
Contributor

@emilsivervik emilsivervik commented Dec 30, 2020 •
edited
Loading

  1. test consuming BufferList which has strings with > 1 items
    https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116

  2. test consuming BufferList with > 1 items
    https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2020
@emilsivervik emilsivervik marked this pull request as ready for review December 30, 2020 13:01
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2020
@emilsivervik emilsivervik force-pushed the test-increase-buffer-list-coverage branch from 0334a00 to 23f7fae Compare January 3, 2021 14:13
@emilsivervik emilsivervik force-pushed the test-increase-buffer-list-coverage branch from 23f7fae to f108d40 Compare January 6, 2021 13:55
@Trott
Copy link
Member

Trott commented Jan 12, 2021

Welcome, @emilsivervik, and thanks for the pull request.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35613/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@jasnell
Copy link
Member

jasnell commented Jan 18, 2021

Landed in 0aef78e

@jasnell jasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
@emilsivervik @jasnell
test: increase buffer list coverage
0aef78e 
1. test consuming BufferList which has strings with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116

2. test consuming BufferList with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152

PR-URL: #36688
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@emilsivervik @ruyadorno
test: increase buffer list coverage
951a78b 
1. test consuming BufferList which has strings with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116

2. test consuming BufferList with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152

PR-URL: #36688
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@emilsivervik @ruyadorno
test: increase buffer list coverage
2f1f1da 
1. test consuming BufferList which has strings with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116

2. test consuming BufferList with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152

PR-URL: #36688
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@emilsivervik @targos
test: increase buffer list coverage
e72b2b4 
1. test consuming BufferList which has strings with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116

2. test consuming BufferList with > 1 items
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152

PR-URL: #36688
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emilsivervik @Trott @nodejs-github-bot @jasnell @watilde @aduh95