Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib(repl): add more primordials instead of builtin #36262

Closed
wants to merge 1 commit into from
Closed

lib(repl): add more primordials instead of builtin #36262

wants to merge 1 commit into from

Conversation

yashLadha
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Nov 25, 2020
@aduh95
Copy link
Contributor

aduh95 commented Nov 25, 2020

Hey, I was working on that in parallel in #36264, would you be interested in picking up the other changes I made in lib/repl.js?

@yashLadha
Copy link
Contributor Author

@aduh95 I think most of the things are already handled in your PR and my changes are just a subset of yours. I can pick your commits and see where I can contribute.

@PoojaDurgad PoojaDurgad added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34996/

@aduh95
Copy link
Contributor

aduh95 commented Dec 18, 2020

@yashLadha should we close this?

@yashLadha
Copy link
Contributor Author

Yes I think we can close this.

@yashLadha yashLadha closed this Dec 18, 2020
@yashLadha yashLadha deleted the fix_add_more_primordials branch December 18, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashLadha @aduh95 @nodejs-github-bot @PoojaDurgad