Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add table header in intl.md #36261

Merged
merged 1 commit into from
Nov 28, 2020
Merged

doc: add table header in intl.md #36261

merged 1 commit into from
Nov 28, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 25, 2020

An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 25, 2020
@Trott
Copy link
Member Author

Trott commented Nov 25, 2020

Before:
image

After:
image

doc/api/intl.md Outdated Show resolved Hide resolved
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

PR-URL: nodejs#36261
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 28, 2020

Landed in 0ac2d0f

@Trott Trott merged commit 0ac2d0f into nodejs:master Nov 28, 2020
@Trott Trott deleted the th branch November 28, 2020 13:15
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

PR-URL: #36261
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
targos pushed a commit that referenced this pull request May 1, 2021
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

PR-URL: #36261
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants