Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: fix "Invalid JWK" error messages #36200

Closed
wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Nov 20, 2020

This PR fixes the typo in webcrypto JWK import messages (JSK -> JWK)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 20, 2020
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@nodejs-github-bot
Copy link
Collaborator

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2020
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 24, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/36200
✔  Done loading data for nodejs/node/pull/36200
----------------------------------- PR info ------------------------------------
Title      crypto: fix "Invalid JWK" error messages (#36200)
Author     Filip Skokan  (@panva)
Branch     panva:fix-webcrypto-typos -> nodejs:master
Labels     C++
Commits    1
 - crypto: fix "Invalid JWK" error messages
Committers 1
 - Filip Skokan 
PR-URL: https://github.com/nodejs/node/pull/36200
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Franziska Hinkelmann 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36200
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Franziska Hinkelmann 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-11-23T09:58:38Z: https://ci.nodejs.org/job/node-test-pull-request/34513/
- Querying data for job/node-test-pull-request/34513/
✔  Build data downloaded
- Querying failures of job/node-test-commit/42424/
✔  Data downloaded
   ✖  1 failure(s) on the last Jenkins CI run
   ℹ  This PR was created on Fri, 20 Nov 2020 20:28:12 GMT
   ✔  Approvals: 3
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36200#pullrequestreview-535761751
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36200#pullrequestreview-535966223
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/36200#pullrequestreview-536306602
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/380749597

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 24, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2020
@github-actions
Copy link
Contributor

Landed in 219332e...4f0f2e7

@github-actions github-actions bot closed this Nov 24, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 24, 2020
PR-URL: #36200
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
PR-URL: #36200
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
@panva panva deleted the fix-webcrypto-typos branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants