Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: Fixing deopt when constructed with strings #3603

Closed
wants to merge 1 commit into from
Closed

buffer: Fixing deopt when constructed with strings #3603

wants to merge 1 commit into from

Commits on Nov 20, 2015

  1. buffer: Fixing deopt when constructed with strings 

    When a buffer was created using `new Buffer('A String')`, internally
within the buffer class we would read arguments[1], however in this case
we would be reading outside of the array causing a deopt to occur.

This fixes this issue by casting the type to a string before use, and
removing the usage of the arguments object.
    @tomgco
    tomgco committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    58296e4 View commit details
    Browse the repository at this point in the history