Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,test: update v8 method doc and comment #35795

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 25, 2020

Update documentation and test comment for v8.cachedDataVersionTag().

Checklist

@Trott Trott force-pushed the cachedDataVersionTag branch 2 times, most recently from 9859b08 to ad97155 Compare October 25, 2020 12:59
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. v8 module Issues and PRs related to the "v8" subsystem. labels Oct 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020
@nodejs-github-bot
Copy link
Collaborator

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #35795 into master will decrease coverage by 8.51%.
The diff coverage is 81.34%.

@@            Coverage Diff             @@
##           master   #35795      +/-   ##
==========================================
- Coverage   96.40%   87.89%   -8.52%     
==========================================
  Files         223      477     +254     
  Lines       73685   113172   +39487     
  Branches        0    25426   +25426     
==========================================
+ Hits        71038    99473   +28435     
- Misses       2647     7996    +5349     
- Partials        0     5703    +5703     
Impacted Files Coverage Δ
src/node_http2.h 92.06% <ø> (ø)
src/node_report.cc 90.71% <ø> (ø)
src/inspector_profiler.cc 76.17% <69.44%> (ø)
lib/internal/dns/utils.js 98.44% <75.00%> (-1.56%) ⬇️
src/cares_wrap.cc 63.42% <77.77%> (ø)
src/node_http2.cc 83.76% <81.25%> (ø)
lib/internal/dns/promises.js 100.00% <100.00%> (ø)
lib/internal/http2/core.js 94.97% <100.00%> (-1.98%) ⬇️
lib/internal/streams/destroy.js 94.66% <100.00%> (-2.19%) ⬇️
lib/internal/streams/from.js 98.01% <100.00%> (ø)
... and 399 more

test/parallel/test-v8-version-tag.js Outdated Show resolved Hide resolved
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2020

Update documentation and test comment for v8.cachedDataVersionTag().

PR-URL: nodejs#35795
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Copy link
Member Author

Trott commented Oct 27, 2020

Landed in 245ec6f

@Trott Trott merged commit 245ec6f into nodejs:master Oct 27, 2020
@Trott Trott deleted the cachedDataVersionTag branch October 27, 2020 13:20
targos pushed a commit that referenced this pull request Nov 3, 2020
Update documentation and test comment for v8.cachedDataVersionTag().

PR-URL: #35795
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
Update documentation and test comment for v8.cachedDataVersionTag().

PR-URL: #35795
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
Update documentation and test comment for v8.cachedDataVersionTag().

PR-URL: #35795
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
Update documentation and test comment for v8.cachedDataVersionTag().

PR-URL: #35795
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 module Issues and PRs related to the "v8" subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants