Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a example code to API doc property in process.md #35738

Closed
wants to merge 3 commits into from

Conversation

PoojaDurgad
Copy link
Contributor

example code added to the process.setgroups() API
doc property in process.md

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

example code added to the process.setgroups() API
doc property in process.md
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Oct 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #35738 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #35738   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         220      223    +3     
  Lines       73675    73685   +10     
=======================================
+ Hits        71025    71035   +10     
  Misses       2650     2650           
Impacted Files Coverage Δ
lib/net.js 95.28% <0.00%> (-0.02%) ⬇️
lib/path/win32.js 100.00% <0.00%> (ø)
lib/path/posix.js 100.00% <0.00%> (ø)
lib/util/types.js 100.00% <0.00%> (ø)
lib/internal/modules/esm/translators.js 95.21% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18651b...1fa3776. Read the comment docs.

doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Oct 22, 2020

I notice that L2207 indicates the array can only contain integers, but the text on L2213 correctly says it can also contain strings (group names). Might be good to update L2207. I'm not sure how to specify "an array of integers and/or strings" but {integer[]|string[]} might be close enough. (To me, that says "an array of integers or an array of strings" but excludes "an array that contains both". Still, that's better than not mentioning strings at all.)

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2020
aduh95 pushed a commit that referenced this pull request Oct 25, 2020
example code added to the process.setgroups() API
doc property in process.md

PR-URL: #35738
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@aduh95
Copy link
Contributor

aduh95 commented Oct 25, 2020

Landed in fc3f41b

@aduh95 aduh95 closed this Oct 25, 2020
targos pushed a commit that referenced this pull request Nov 3, 2020
example code added to the process.setgroups() API
doc property in process.md

PR-URL: #35738
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
example code added to the process.setgroups() API
doc property in process.md

PR-URL: #35738
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
example code added to the process.setgroups() API
doc property in process.md

PR-URL: #35738
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
example code added to the process.setgroups() API
doc property in process.md

PR-URL: #35738
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants