Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update gyp-next to v0.6.0 #35635

Closed
wants to merge 2 commits into from
Closed

Conversation

ryzokuken
Copy link
Contributor

Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @MylesBorins @rvagg @targos

@ryzokuken ryzokuken self-assigned this Oct 13, 2020
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 13, 2020
@ryzokuken
Copy link
Contributor Author

@rvagg can you push the test update commit into this branch? I believe you should be able to do that.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@MylesBorins
Copy link
Contributor

fast-track?

@MylesBorins MylesBorins added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 13, 2020
@ryzokuken
Copy link
Contributor Author

@MylesBorins I thought the change at node-gyp was more time sensitive? But either way, I'm 👍 for fast-tracking.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

@MylesBorins
Copy link
Contributor

@ryzokuken they are all time sensitive but afaik node-gyp itself doesn't have a fast track :P

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen
Copy link
Member

cc @rvagg https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_shared_x64/22824/console

08:43:26 not ok 1526 parallel/test-module-loading-globalpaths
08:43:26   ---
08:43:26   duration_ms: 0.212
08:43:26   severity: fail
08:43:26   exitcode: 1
08:43:26   stack: |-
08:43:26     /home/iojs/node-tmp/.tmp.1526/install/bin/node: error while loading shared libraries: libnode.so.86: cannot open shared object file: No such file or directory
08:43:26     node:assert:680
08:43:26         throw err;
08:43:26         ^
08:43:26     
08:43:26     AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Cannot find module 'foo'/. Input:

@rvagg rvagg added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2020
@nodejs-github-bot
Copy link
Collaborator

@rvagg
Copy link
Member

rvagg commented Oct 14, 2020

this is good to go now, I've added in the commit from #35626 and CI is happy

@ryzokuken
Copy link
Contributor Author

Since everything passes and we agreed to fast-track this, I'm going to land this.

ryzokuken added a commit that referenced this pull request Oct 14, 2020
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0

PR-URL: #35635
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
ryzokuken pushed a commit that referenced this pull request Oct 14, 2020
Ref: nodejs/node-gyp#2233
Ref: nodejs/gyp-next#69

PR-URL: #35635
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@ryzokuken
Copy link
Contributor Author

Landed in d5e6495...999e7d7. 🎉

@ryzokuken ryzokuken closed this Oct 14, 2020
@MylesBorins
Copy link
Contributor

hey @nodejs/node-gyp should we be updating the version of gyp-next on v14.x LTS? If so can we get a backport PR so we can test it.

@gengjiawen
Copy link
Member

hey @nodejs/node-gyp should we be updating the version of gyp-next on v14.x LTS? If so can we get a backport PR so we can test it.

@MylesBorins Yeap, backport looks good to me.

BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0

PR-URL: #35635
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
Ref: nodejs/node-gyp#2233
Ref: nodejs/gyp-next#69

PR-URL: #35635
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0

PR-URL: nodejs#35635
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Ref: nodejs/node-gyp#2233
Ref: nodejs/gyp-next#69

PR-URL: nodejs#35635
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Aug 18, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0

PR-URL: nodejs#35635
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants