use case-sensitive in the example #35624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
richardlau
approved these changes
Oct 13, 2020
Trott
approved these changes
Oct 13, 2020
lpinca
approved these changes
Oct 13, 2020
gireeshpunathil
approved these changes
Oct 27, 2020
gireeshpunathil
added
author ready
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/35624 ✔ Done loading data for nodejs/node/pull/35624 ----------------------------------- PR info ------------------------------------ Title use case-sensitive in the example (#35624) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch PoojaDurgad:process-getreport -> nodejs:master Labels author ready, doc, process Commits 1 - doc: use case-sensitive in the example Committers 1 - Pooja D.P PR-URL: https://github.com/nodejs/node/pull/35624 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Gireesh Punathil ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35624 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Gireesh Punathil -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Tue, 13 Oct 2020 04:48:34 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35624#pullrequestreview-507076375 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35624#pullrequestreview-507320736 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35624#pullrequestreview-507750801 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/35624#pullrequestreview-517357421 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/330626537 |
trivikr
approved these changes
Oct 27, 2020
aduh95
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 0ca8617...cb62f16 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 27, 2020
PR-URL: #35624 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35624 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #35624 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35624 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35624 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes