Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document rmdir/recursive deprecation #35579

Closed
wants to merge 5 commits into from
Closed

doc: document rmdir/recursive deprecation #35579

wants to merge 5 commits into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 9, 2020 •
edited
Loading

Document deprecation of rmdir/recursive permissive functionality.

As suggested by @aduh95, this adds the deprecation of the permissive behavior of rmdir/recursive as a docs only deprecation, in the deprecations.md.

We already updated the docs in #35171, to mention that the permissive behavior will one day be removed.

Refs: #35562

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

CC: @iansu

@bcoe
doc: document rmdir/recursive deprecation
33a6326 
Document deprecation of rmdir/recursive permissive functionality
@bcoe bcoe requested review from Trott, BridgeAR and aduh95 October 9, 2020 22:05
@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 9, 2020
addaleax
addaleax reviewed Oct 9, 2020
View reviewed changes
doc/api/deprecations.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Oct 9, 2020
View reviewed changes
doc/api/deprecations.md Outdated Show resolved Hide resolved
bcoe and others added 2 commits October 9, 2020 18:10
@bcoe @addaleax
Update doc/api/deprecations.md
84d4d64 
Co-authored-by: Anna Henningsen <github@addaleax.net>
@bcoe
chore: address code review
a0372b2
@bcoe bcoe requested review from addaleax and Trott October 10, 2020 01:18
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@bcoe bcoe added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33534/

bcoe added a commit that referenced this pull request Oct 12, 2020
@bcoe
doc: document rmdir/recursive deprecation
c759281 
Document deprecation of rmdir/recursive permissive functionality

PR-URL: #35579
Refs: #35562
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@bcoe
Copy link
Contributor Author

bcoe commented Oct 12, 2020

Landed in c759281

@bcoe bcoe closed this Oct 12, 2020
@bcoe bcoe deleted the document-rmdir-recurse-deprecation branch October 12, 2020 16:46
@bcoe bcoe mentioned this pull request Oct 12, 2020
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@bcoe @MylesBorins
doc: document rmdir/recursive deprecation
809cd07 
Document deprecation of rmdir/recursive permissive functionality

PR-URL: #35579
Refs: #35562
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@bcoe @joesepi
doc: document rmdir/recursive deprecation
42b65ed 
Document deprecation of rmdir/recursive permissive functionality

PR-URL: nodejs#35579
Refs: nodejs#35562
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95 aduh95 mentioned this pull request Aug 10, 2021
Closed
jasnell pushed a commit that referenced this pull request Aug 12, 2021
@aduh95 @jasnell
doc: fix fs.rmdir recursive option deprecation history
1c7a19b 
PR-URL: #39728
Refs: #35579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@aduh95 @danielleadams
doc: fix fs.rmdir recursive option deprecation history
338a166 
PR-URL: #39728
Refs: #35579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
@aduh95 @targos
doc: fix fs.rmdir recursive option deprecation history
49a7962 
PR-URL: #39728
Refs: #35579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@iansu iansu iansu approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bcoe @nodejs-github-bot @iansu @Trott @addaleax @targos @aduh95