-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove http2 non-link anchor tags #35161
Conversation
Review requested:
|
I kind of wish we’d go into the opposite direction more often – these anchor tags allow creating permanently functional links from other websites to the documentation, while the automatically generated anchors can easily change even when only a minor change to the header text was performed and break those links. I would keep them. |
I can definitely support that to accommodate links from external pages, but these were apparently created to have links from within the page, and I'm not sure we want to encourage that. |
Landed in b569376 |
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
this change doesn't land cleanly on v14.x, should it be backported? |
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno Backport in #35334. |
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.
Checklist