Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix broken link in http2.md #35112

Merged
merged 1 commit into from
Sep 11, 2020
Merged

doc: fix broken link in http2.md #35112

merged 1 commit into from
Sep 11, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 9, 2020

Checklist

@Trott Trott requested review from a team as code owners September 9, 2020 00:17
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Sep 9, 2020
@rickyes rickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 9, 2020
mhdawson
mhdawson approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Sep 11, 2020

Landed in 85624fd

@Trott Trott merged commit 85624fd into nodejs:master Sep 11, 2020
@Trott Trott deleted the http2-link branch September 11, 2020 02:45
@Trott
doc: fix broken link in http2.md
85624fd 
PR-URL: nodejs#35112
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
@Trott @ruyadorno
doc: fix broken link in http2.md
5c8d208 
PR-URL: #35112
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: fix broken link in http2.md
1e39820 
PR-URL: #35112
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: fix broken link in http2.md
b03f00d 
PR-URL: nodejs#35112
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@addaleax addaleax addaleax approved these changes

@mhdawson mhdawson mhdawson approved these changes

@trivikr trivikr trivikr approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@MrHeer MrHeer MrHeer approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @fhinkel @addaleax @mhdawson @trivikr @DerekNonGeneric @MrHeer @rickyes