crypto: fix randomInt range check #35052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
crypto
4 tasks
richardlau
approved these changes
Sep 4, 2020
github-actions
bot
removed
the
request-ci
richardlau
added
the
author ready
lundibundi
approved these changes
Sep 4, 2020
cjihrig
approved these changes
Sep 4, 2020
mscdex
reviewed
Sep 4, 2020
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35052 ✔ Done loading data for nodejs/node/pull/35052 ----------------------------------- PR info ------------------------------------ Title crypto: fix randomInt range check (#35052) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:crypto-fix-randomint-range-check -> nodejs:master Labels author ready, crypto Commits 2 - crypto: fix randomInt range check - fixup! crypto: fix randomInt range check Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/35052 Refs: https://github.com/nodejs/node/pull/34600 Reviewed-By: Richard Lau Reviewed-By: Denys Otrishko Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35052 Refs: https://github.com/nodejs/node/pull/34600 Reviewed-By: Richard Lau Reviewed-By: Denys Otrishko Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup! crypto: fix randomInt range check ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-09-07T10:54:14Z: https://ci.nodejs.org/job/node-test-pull-request/33088/ - Querying data for job/node-test-pull-request/33088/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Fri, 04 Sep 2020 10:18:12 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35052#pullrequestreview-482554674 ✔ - Denys Otrishko (@lundibundi): https://github.com/nodejs/node/pull/35052#pullrequestreview-482579029 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/35052#pullrequestreview-482658703 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
github-actions
bot
added
the
commit-queue-failed
richardlau
approved these changes
Sep 7, 2020
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in cb2b82b |
richardlau
removed
the
commit-queue-failed
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: nodejs#34600 PR-URL: nodejs#35052 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation allows
crypto.randomInt(0)and returnsNaN.Refs: #34600
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes