Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 4.6.85.28 #3484

Merged
merged 1 commit into from
Oct 23, 2015
Merged

deps: update V8 to 4.6.85.28 #3484

merged 1 commit into from
Oct 23, 2015

Conversation

targos
Copy link
Member

@targos targos commented Oct 22, 2015

This update fixes a breaking regression in the date parser.
Ref: https://code.google.com/p/chromium/issues/detail?id=539813
Ref: https://code.google.com/p/chromium/issues/detail?id=543320

cc @nodejs/v8

@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Oct 22, 2015
@targos targos added this to the 5.0.0 milestone Oct 22, 2015
@bnoordhuis
Copy link
Member

Technically LGTM but if I read it right, this changes date parsing back from ES6 conforming to ES5. I understand that for Chromium not breaking the web is important but for us though, it's arguably a semver-major change...

@targos
Copy link
Member Author

targos commented Oct 22, 2015

I understand that the change appeared with v8 4.6 so we don't have any release with it yet.

@targos
Copy link
Member Author

targos commented Oct 22, 2015

This is why I think it's important to update before releasing v5.0.0.

@bnoordhuis
Copy link
Member

Oh hah, good point. Never mind I said that.

EDIT: Double-checked that the change is not in 4.5 and it's not.

@targos
Copy link
Member Author

targos commented Oct 22, 2015

This update fixes a breaking regression in the date parser.

Ref: https://code.google.com/p/chromium/issues/detail?id=539813
Ref: https://code.google.com/p/chromium/issues/detail?id=543320
PR-URL: nodejs#3484
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos merged commit 6456fcf into nodejs:master Oct 23, 2015
@targos targos deleted the v8-update branch October 23, 2015 06:02
@targos
Copy link
Member Author

targos commented Oct 23, 2015

Landed in 6456fcf.

targos added a commit that referenced this pull request Oct 26, 2015
This update fixes a breaking regression in the date parser.

Ref: https://code.google.com/p/chromium/issues/detail?id=539813
Ref: https://code.google.com/p/chromium/issues/detail?id=543320
PR-URL: #3484
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants