Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: enable renegotiation when using boringssl #34832

Closed
wants to merge 1 commit into from
Closed

tls: enable renegotiation when using boringssl #34832

wants to merge 1 commit into from

Conversation

nornagon
Copy link
Contributor

This enables TLS renegotiation when building Node with BoringSSL, which matches
OpenSSL's default behavior.

No effect when building against OpenSSL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Aug 18, 2020
@nornagon nornagon mentioned this pull request Aug 18, 2020
Merged
5 tasks
@mmarchini mmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2020
@mscdex
Copy link
Contributor

mscdex commented Aug 18, 2020

nit: it would be better to spell out BoringSSL in the first line of the commit message for those who aren't familiar with "bssl"

@nornagon nornagon changed the title tls: enable renegotiation when using bssl tls: enable renegotiation when using boringssl Aug 18, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32884/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 21, 2020
Trott pushed a commit that referenced this pull request Aug 22, 2020
@nornagon @Trott
tls: enable renegotiation when using BoringSSL
8e8d429 
PR-URL: #34832
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau
Copy link
Member

Landed (by @Trott) in 8e8d429.

@richardlau richardlau closed this Aug 22, 2020
@Trott
Copy link
Member

Trott commented Aug 22, 2020

Landed (by @Trott) in 8e8d429.

I am really good with typing things in the wrong browser window. Thanks for fixing it.

@richardlau
Copy link
Member

Landed (by @Trott) in 8e8d429.

I am really good with typing things in the wrong browser window. Thanks for fixing it.

No harm done, I was just really confused initially because the other PR wasn't landable.

BethGriggs pushed a commit that referenced this pull request Aug 24, 2020
@nornagon @BethGriggs
tls: enable renegotiation when using BoringSSL
e90cb49 
PR-URL: #34832
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 25, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@nornagon @addaleax
tls: enable renegotiation when using BoringSSL
b80921c 
PR-URL: #34832
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@nornagon @addaleax
tls: enable renegotiation when using BoringSSL
c059d3d 
PR-URL: #34832
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@codebytere codebytere codebytere approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.