Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allow ENFILE in test-worker-init-failure #34769

Merged
merged 0 commits into from
Aug 16, 2020
Merged

test: allow ENFILE in test-worker-init-failure #34769

merged 0 commits into from
Aug 16, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 14, 2020

Refs: #34727 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 14, 2020
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 14, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 14, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32776/

@Trott
Copy link
Member Author

Trott commented Aug 14, 2020

I've added ENOENT as well. PTAL.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 14, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32794/ ✅

@github-actions github-actions bot mentioned this pull request Aug 15, 2020
Open
6 tasks
bnoordhuis
bnoordhuis approved these changes Aug 15, 2020
View reviewed changes
test/parallel/test-worker-init-failure.js Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Aug 16, 2020
Open
6 tasks
@Trott
Copy link
Member Author

Trott commented Aug 16, 2020

Landed in 375b859...0e1fd8d

Trott added a commit to Trott/io.js that referenced this pull request Aug 16, 2020
@Trott
test: allow ENFILE in test-worker-init-failure
97d9b9c 
Refs: nodejs#34727 (comment)

PR-URL: nodejs#34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@Trott Trott closed this Aug 16, 2020
@Trott Trott merged commit 0e1fd8d into nodejs:master Aug 16, 2020
@Trott Trott deleted the enfile branch August 16, 2020 14:40
@github-actions github-actions bot mentioned this pull request Aug 17, 2020
Open
6 tasks
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@Trott @MylesBorins
test: allow ENFILE in test-worker-init-failure
fcb5d95 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@Trott @MylesBorins
test: allow ENOENT in test-worker-init-failure
b202ba8 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@github-actions github-actions bot mentioned this pull request Aug 18, 2020
Open
5 tasks
This was referenced Aug 19, 2020
Open
Open
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
test: allow ENFILE in test-worker-init-failure
88919e5 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
test: allow ENOENT in test-worker-init-failure
1c324d5 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@github-actions github-actions bot mentioned this pull request Aug 21, 2020
Open
9 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: allow ENFILE in test-worker-init-failure
ac620b0 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: allow ENOENT in test-worker-init-failure
7c09012 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: allow ENFILE in test-worker-init-failure
238d01f 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: allow ENOENT in test-worker-init-failure
5352cde 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@lundibundi lundibundi lundibundi approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @bnoordhuis @addaleax @lpinca @richardlau @gireeshpunathil @lundibundi @rickyes