Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix checkimports.py when passed arguments #34581

Closed
wants to merge 2 commits into from
Closed

tools: fix checkimports.py when passed arguments #34581

wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

Fix checkimports.py so that all passed arguments are checked instead
of just the first one.

Opening as a draft to check that our actions/CI jobs fail properly now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@richardlau
tools: fix checkimports.py when passed arguments
b41995f 
Fix checkimports.py so that all passed arguments are checked instead
of just the first one.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4185

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 31, 2020
@richardlau
Copy link
Member Author

Close in favour of #34582.

@richardlau richardlau closed this Jul 31, 2020
@richardlau richardlau deleted the checkimports branch July 31, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardlau @nodejs-github-bot