Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: onboarding process extras #34455

Closed

Conversation

gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Jul 21, 2020

Callout some practices explicitly, so that the process is followed in a similar manner

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 21, 2020
@puzpuzpuz puzpuzpuz self-requested a review July 21, 2020 07:03
@sxa
Copy link
Member

sxa commented Jul 21, 2020

Related question: Is it common for onboarding to be done with just one existing collaborator present?

@gireeshpunathil
Copy link
Member Author

@sxa - it happened twice recently: here, #34457 and here: #34417

onboarding.md Outdated Show resolved Hide resolved
gireeshpunathil added a commit that referenced this pull request Jul 24, 2020
Callout some practices explicitly, so that
the process is followed in a similar manner

PR-URL: #34455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@gireeshpunathil
Copy link
Member Author

landed in 983364c

MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Callout some practices explicitly, so that
the process is followed in a similar manner

PR-URL: #34455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Callout some practices explicitly, so that
the process is followed in a similar manner

PR-URL: #34455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Callout some practices explicitly, so that
the process is followed in a similar manner

PR-URL: #34455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants