-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: allow preventing SetPromiseRejectCallback #34387
Closed
codebytere
wants to merge
1
commit into
nodejs:master
from
codebytere:allow-preventing-SetPromiseRejectCallback
Closed
src: allow preventing SetPromiseRejectCallback #34387
codebytere
wants to merge
1
commit into
nodejs:master
from
codebytere:allow-preventing-SetPromiseRejectCallback
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
devsnek
approved these changes
Jul 16, 2020
addaleax
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think it makes sense to use the inverse flag (i.e. SHOULD_NOT_SET_PROMISE_REJECTION_CALLBACK
), because then this becomes semver-minor instead :)
0e4958e
to
8862256
Compare
jasnell
approved these changes
Jul 17, 2020
tniessen
approved these changes
Jul 17, 2020
This was referenced Jul 18, 2020
8862256
to
5eec3ac
Compare
devsnek
reviewed
Jul 20, 2020
5eec3ac
to
267c4c9
Compare
addaleax
reviewed
Jul 20, 2020
267c4c9
to
a7a5972
Compare
10 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
PR-URL: #34387 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
3 tasks
ruyadorno
added a commit
that referenced
this pull request
Jul 28, 2020
Notable changes: dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500 doc: * add AshCripps to collaborators (AshCripps) #34494 * add HarshithaKP to collaborators (Harshitha K P) #34417 * add rexagod to collaborators (Pranshu Srivastava) #34457 * add release key for Richard Lau (Richard Lau) #34397 events: * (SEMVER-MINOR) expand NodeEventTarget functionality (Anna Henningsen) #34057 src: * (SEMVER-MINOR) allow preventing SetPromiseRejectCallback (Shelley Vohr) #34387 * (SEMVER-MINOR) allow setting a dir for all diagnostic output (AshCripps) #33584 worker: * (SEMVER-MINOR) make MessagePort inherit from EventTarget (Anna Henningsen) #34057 PR-URL: TODO
Merged
ruyadorno
added a commit
that referenced
this pull request
Jul 28, 2020
Notable changes: dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500 doc: * add AshCripps to collaborators (AshCripps) #34494 * add HarshithaKP to collaborators (Harshitha K P) #34417 * add rexagod to collaborators (Pranshu Srivastava) #34457 * add release key for Richard Lau (Richard Lau) #34397 events: * (SEMVER-MINOR) expand NodeEventTarget functionality (Anna Henningsen) #34057 src: * (SEMVER-MINOR) allow preventing SetPromiseRejectCallback (Shelley Vohr) #34387 * (SEMVER-MINOR) allow setting a dir for all diagnostic output (AshCripps) #33584 worker: * (SEMVER-MINOR) make MessagePort inherit from EventTarget (Anna Henningsen) #34057 zlib: * switch to lazy init for zlib streams (Andrey Pechkurov) #34048 PR-URL: #34542
ruyadorno
added a commit
that referenced
this pull request
Jul 29, 2020
Notable changes: deps: * upgrade npm to 6.14.7 (claudiahdz) #34468 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500 doc: * add AshCripps to collaborators (AshCripps) #34494 * add HarshithaKP to collaborators (Harshitha K P) #34417 * add rexagod to collaborators (Pranshu Srivastava) #34457 * add release key for Richard Lau (Richard Lau) #34397 events: * (SEMVER-MINOR) expand NodeEventTarget functionality (Anna Henningsen) #34057 src: * (SEMVER-MINOR) allow preventing SetPromiseRejectCallback (Shelley Vohr) #34387 * (SEMVER-MINOR) allow setting a dir for all diagnostic output (AshCripps) #33584 worker: * (SEMVER-MINOR) make MessagePort inherit from EventTarget (Anna Henningsen) #34057 zlib: * switch to lazy init for zlib streams (Andrey Pechkurov) #34048 PR-URL: #34542
MylesBorins
pushed a commit
that referenced
this pull request
Jul 29, 2020
Notable changes: deps: * upgrade npm to 6.14.7 (claudiahdz) #34468 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500 doc: * add AshCripps to collaborators (AshCripps) #34494 * add HarshithaKP to collaborators (Harshitha K P) #34417 * add rexagod to collaborators (Pranshu Srivastava) #34457 * add release key for Richard Lau (Richard Lau) #34397 events: * (SEMVER-MINOR) expand NodeEventTarget functionality (Anna Henningsen) #34057 src: * (SEMVER-MINOR) allow preventing SetPromiseRejectCallback (Shelley Vohr) #34387 * (SEMVER-MINOR) allow setting a dir for all diagnostic output (AshCripps) #33584 worker: * (SEMVER-MINOR) make MessagePort inherit from EventTarget (Anna Henningsen) #34057 zlib: * switch to lazy init for zlib streams (Andrey Pechkurov) #34048 PR-URL: #34542
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 1, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 1, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 2, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 4, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 14, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 14, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 14, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 16, 2020
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34387 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
embedding
Issues and PRs related to embedding Node.js in another project.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly augments the existing
IsolateSettings
struct for embedder purposes.Electron does not want to use the promise rejection callback that Node.js uses,
because it does not send
PromiseRejectionEvents
to the global script context in the browser (for fairly obvious reasons).Therefore, if we want to use Node.js setup logic in the renderer process (as opposed to standalone embedded mode, where we already do this) we would not be able to allow users to do things such as:
since the
'unhandledrejection'
event would never be fired.We need to use the one Blink already provides and sets on the Isolate we're given, and so we need to slightly augment
IsolateSettings
to allow for that.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes