Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http2-invalidheaderfield #34173

Closed
wants to merge 0 commits into from
Closed

test: fix flaky test-http2-invalidheaderfield #34173

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 2, 2020

Separate test cases to avoid side effects and race conditions.

Fixes: #34172

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 2, 2020
@Trott
Copy link
Member Author

Trott commented Jul 2, 2020

I would like to fast-track this to unbreak CI. 👍 here to approve if you're a collaborator.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 2, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32193/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 2, 2020
Trott added a commit that referenced this pull request Jul 3, 2020
@Trott
test: fix flaky test-http2-invalidheaderfield
9b8d317 
Separate test cases to avoid side effects and race conditions.

Fixes: #34172

PR-URL: #34173
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@Trott Trott closed this Jul 3, 2020
@Trott
Copy link
Member Author

Trott commented Jul 3, 2020

Landed in 9b8d317

@Trott Trott deleted the fix-flaky-http2 branch July 3, 2020 15:45
@MylesBorins
Copy link
Contributor

Marked as don't land fo 10.x, 12.x, and 14.x as the test this fixes landed in a Semver-Major commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix flaky test-http2-invalidheaderfield
5 participants
@Trott @nodejs-github-bot @MylesBorins @addaleax @puzpuzpuz