Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add maxTotalSockets option to agent constructor #34013

Closed
wants to merge 4 commits into from
Closed

doc: Add maxTotalSockets option to agent constructor #34013

wants to merge 4 commits into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Jun 22, 2020

Refs: #33617

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jun 22, 2020
@rickyes
Copy link
Contributor Author

rickyes commented Jun 23, 2020

/cc @ronag @mcollina

Trott
Trott reviewed Jun 24, 2020
View reviewed changes
doc/api/http.md Show resolved Hide resolved
Trott
Trott previously requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting in "Request changes" until we get clarity on the PR-URL value and whether REPLACEME is right for version or not....

@Trott
Copy link
Member

Trott commented Jun 24, 2020

Putting in "Request changes" until we get clarity on the PR-URL value and whether REPLACME is right for version or not....

@nodejs/documentation

@rickyes
Copy link
Contributor Author

rickyes commented Jun 28, 2020

Putting in "Request changes" until we get clarity on the PR-URL value and whether REPLACME is right for version or not....

#33617 is going to be released on v14.5.0(#34093), and I'm change the value of the version to 14.5.0.

@rickyes rickyes force-pushed the add-maxTotalSockets-to-agents-options branch from ac9b92b to b093f5e Compare July 1, 2020 02:33
@rickyes
Copy link
Contributor Author

rickyes commented Jul 1, 2020

Putting in "Request changes" until we get clarity on the PR-URL value and whether REPLACME is right for version or not....

@Trott done

@Trott Trott dismissed their stale review July 1, 2020 21:53

Change request addressed

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2020
jasnell pushed a commit that referenced this pull request Jul 3, 2020
@rickyes @jasnell
doc: Add maxTotalSockets option to agent constructor
a7c6806 
PR-URL: #34013
Refs: #33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jul 3, 2020

Landed in a7c6806

@jasnell jasnell closed this Jul 3, 2020
@rickyes rickyes deleted the add-maxTotalSockets-to-agents-options branch July 5, 2020 03:41
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@rickyes @MylesBorins
doc: Add maxTotalSockets option to agent constructor
694ad8c 
PR-URL: #34013
Refs: #33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@rickyes @MylesBorins
doc: Add maxTotalSockets option to agent constructor
e273edf 
PR-URL: #34013
Refs: #33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere
Copy link
Member

@rickyes does this apply to v12.x?

rickyes added a commit to rickyes/node that referenced this pull request Sep 28, 2020
@rickyes
doc: Add maxTotalSockets option to agent constructor
0a507d1 
PR-URL: nodejs#34013
Refs: nodejs#33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes rickyes mentioned this pull request Sep 28, 2020
Closed
4 tasks
@rickyes
Copy link
Contributor Author

rickyes commented Sep 28, 2020

@codebytere backport in #35396

addaleax pushed a commit that referenced this pull request Sep 28, 2020
@rickyes @addaleax
doc: Add maxTotalSockets option to agent constructor
1a8669d 
PR-URL: #34013
Backport-PR-URL: #35396
Refs: #33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #33617
Fixes: #31942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rickyes @Trott @jasnell @codebytere @ronag @addaleax @nodejs-github-bot