-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: use and support non-empty DATA frame with END_STREAM flag #33875
Closed
Commits on Jun 18, 2020
-
http2: use and support non-empty DATA frame with END_STREAM flag
Adds support for reading from a stream where the final frame is a non-empty DATA frame with the END_STREAM flag set, instead of hanging waiting for another frame. When writing to a stream, uses a END_STREAM flag on final DATA frame instead of adding an empty DATA frame. BREAKING: http2 client now expects servers to properly support END_STREAM flag Fixes: nodejs#31309 Fixes: nodejs#33891 Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback
Configuration menu - View commit details
-
Copy full SHA for ca21bd1 - Browse repository at this point
Copy the full SHA ca21bd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e35afd - Browse repository at this point
Copy the full SHA 1e35afdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30b1c06 - Browse repository at this point
Copy the full SHA 30b1c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f7c361 - Browse repository at this point
Copy the full SHA 6f7c361View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbddeb6 - Browse repository at this point
Copy the full SHA cbddeb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for acb5999 - Browse repository at this point
Copy the full SHA acb5999View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85cf722 - Browse repository at this point
Copy the full SHA 85cf722View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bae5a5 - Browse repository at this point
Copy the full SHA 7bae5a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 789cc1d - Browse repository at this point
Copy the full SHA 789cc1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c110d0 - Browse repository at this point
Copy the full SHA 0c110d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 563a310 - Browse repository at this point
Copy the full SHA 563a310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 327e9e8 - Browse repository at this point
Copy the full SHA 327e9e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58a3885 - Browse repository at this point
Copy the full SHA 58a3885View commit details
Commits on Jun 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1778fc6 - Browse repository at this point
Copy the full SHA 1778fc6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.