http: emit 'close' when sockets are not constructed #33818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OutgoingMessage#socket` is `null` for such cases at all times. Hence, we emit a 'close' event, imitating `destroyImpl.destroy`, without the socket operations. Fixes: nodejs#33653
jasnell
reviewed
Jun 10, 2020
jasnell
approved these changes
Jun 10, 2020
Co-authored-by: James M Snell <jasnell@gmail.com>
|
ping @mcollina |
mcollina
reviewed
Jun 14, 2020
| @@ -296,6 +296,9 @@ OutgoingMessage.prototype.destroy = function destroy(error) { | |||
| }); | |||
| } | |||
|
|
|||
| if (this instanceof OutgoingMessage) { | |||
There was a problem hiding this comment.
I added this to check for instances where no sockets were constructed, as in msg = new OutgoingMessage (similar to the code snippet in the original issue #33653).
We should always emit a close, eventually... Though I don't think the implementation in this PR is correct. When we do get a socket Just so that I understand a bit better... the current code assumes that a socket will always was be assigned eventually... in which case is this false? The test is not a good example since it's never actually used like that. |
ronag
requested changes
Jun 14, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutgoingMessage#socketisnullfor such cases at all times.Hence, we emit a 'close' event, imitating
destroyImpl.destroy,without the socket operations.
Fixes: #33653
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes